-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Release OCaml/Unikraft 1.1.0 #28750
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Release OCaml/Unikraft 1.1.0 #28750
Conversation
…ends The constraint is not needed for the 0.18.0 and 0.20.0 versions of the toolchain packages (as the build system is the same for those versions of these packages) but a version mismatch makes little sense anyhow and could cause issues down the line
Changes: - Support for OCaml 5.4.0 and Unikraft 0.20.0 - Various fixes, in particular an issue where the OCaml cross compiler failed to build in an opam local switch
|
Analysis of the Opam CI results:
For 1., I wonder whether we should try to exclude older GCCs, but I don’t know what’s the best way to do so. |
|
Thanks - also for the CI summary! 🙏 For 4., we might consider adding |
I think I had tried to do that for the previous release but it was failing regardless. If I remember correctly, my conclusion at the time was that this entry was no longer working as hoped. |
|
I've created #28829 to fix 2. |
packages/ocaml-unikraft-toolchain-arm64/ocaml-unikraft-toolchain-arm64.0.20.0/opam
Show resolved
Hide resolved
|
OK, that didn't work... Should the line also be added to |
I had tried that last time for Tumbleweed at least according to the record (1, 2) but we could retry with a better set of exceptions. |
Hm. It seems this checks failure by seeing which directories are left in Looking more at the implementation in |
|
So I added a patch that changes the build failure exception in the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My bad! 😅
packages/conf-aarch64-linux-gnu-gcc/conf-aarch64-linux-gnu-gcc.1/opam
Outdated
Show resolved
Hide resolved
packages/ocaml-unikraft-toolchain-arm64/ocaml-unikraft-toolchain-arm64.0.20.0/opam
Outdated
Show resolved
Hide resolved
70279c1 to
6d11691
Compare
|
Thanks for triggering a new build after #28829 has been merged! The noise is already significantly down 🥳 A couple of questions:
|
Two minds with but a single thought 😄
Good idea, thank you! |
Co-authored-by: Jan Midtgaard <[email protected]>
a2f04e8 to
27d77bf
Compare
Changes
This PR proposes also to align the 0.18.0 versions of the
ocaml-unikraft-toolchain-*packages with the new versions, to make sure the same version number is used across all backend packages.